Added store options to the migration process#6
Open
AndrewMcDrew wants to merge 1 commit intoalo7:masterfrom
Open
Added store options to the migration process#6AndrewMcDrew wants to merge 1 commit intoalo7:masterfrom
AndrewMcDrew wants to merge 1 commit intoalo7:masterfrom
Conversation
|
@AndrewMcDrew, Probably the conflicts should be solved in this branch so it would be possible to merge, now GitHub says there are conflicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some
NSPersistentStoresubclasses rely on the "options" dictionary, so the default implementation doesn't work.As you can see,
NSPersistentStoreCoordinator'smetadataForPersistentStoreOfType:method usage was removed and it's reimplementation was added. The reason for this is the fact that this method ignoresoptionsdictionary, passed in, and substitutes it with it's own dictionary. I don't know why. But this dictionary is vital for opening the store.Additionally there is a handy
NSPersistentStoreCoordinatorcategory.